SplatPager: null texture source to ensure underlying arrays can be GC'ed#326
Merged
Conversation
Co-authored-by: Aleksandr Korotaev <lekzd@mail.ru>
Contributor
|
@mrxz I confirm it fixes biggest memory leak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative PR to #320 that nulls the texture source data. This removes all references to the underlying TypedArrays instead of only clearing the reference from
SplatPager -> Texture. Since these textures are also referenced from (cached) shader materials, this avoids having to hunt them down manually.Ultimately it's still a crude approach, but at least ensures no large memory leaks occur. A proper solution would be to ensure that the cached shader materials are disposed of. This way no references to the textures should remain, allowing them to GC'ed normally.